[ELY-1876] Log messages are not logged when KeyStoreCredentialStore is initialized with Provider[] in getKeyStoreInstance. #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skyllarr
approved these changes
Sep 20, 2019
fjuma
requested changes
Oct 29, 2019
| @@ -919,9 +919,14 @@ private void load(String type) throws CredentialStoreException { | |||
|
|
|||
| private KeyStore getKeyStoreInstance(String type) throws CredentialStoreException { | |||
| if (providers != null) { | |||
| if (log.isTraceEnabled()) { | |||
| log.tracef("Obtaining KeyStore instance of type %s, providers: %s", type, providers); | |||
There was a problem hiding this comment.
Would be good to use Arrays.toString(providers)
There was a problem hiding this comment.
@fjuma Updated to use Arrays.toString(). Thanks!
initialized with Provider[] in getKeyStoreInstance.
ivassile
force-pushed
the
ELY-1876_1.x
branch
from
85d546c
to
eaebb5b
Compare
fjuma
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ELY-1876