Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELY-1724] Develop an alternative to 'org.wildfly.security.credential.source.OAuth2CredentialSource' #1333

Conversation

ashley-abdelsayed98
Copy link
Contributor

@ashley-abdelsayed98 ashley-abdelsayed98 commented Sep 17, 2019

@wildfly-ci
Copy link

Can one of the admins verify this patch?

@darranl darranl added the master label Sep 20, 2019
@ashley-abdelsayed98 ashley-abdelsayed98 changed the title [ELY-1724][ELY-1725] Develop an alternative and then remove 'org.wildfly.security.credential.source.OAuth2CredentialSource' [ELY-1724] Develop an alternative to 'org.wildfly.security.credential.source.OAuth2CredentialSource' Sep 20, 2019
@wildfly-ci
Copy link

Linux - JDK11 EA 28 Build 327 outcome was FAILURE using a merge of 8fd50b9
Summary: Exit code 1 (Step: Maven) (new) Build time: 00:00:11

@wildfly-ci
Copy link

Windows Build 328 outcome was FAILURE using a merge of 8fd50b9
Summary: Exit code 1 (Step: Maven) (new) Build time: 00:00:19

@wildfly-ci
Copy link

Linux - JDK11 EA 28 Build 333 outcome was FAILURE using a merge of 8fd50b9
Summary: Exit code 1 (Step: Maven) Build time: 00:00:12

@wildfly-ci
Copy link

Windows Build 334 outcome was FAILURE using a merge of 8fd50b9
Summary: Exit code 1 (Step: Maven) Build time: 00:00:16

@darranl
Copy link
Contributor

darranl commented Feb 7, 2020

I think once @fjuma is available we are ready to have another look at this one, I think there are a couple of points to discuss a bit further.

Firstly it would be good if we could get the new implementation into the 1.x branch in parallel with the original implementation so people can move from the deprecated version immediately. Those that move early are then not impacted when the removal happens in the next minor release.

Secondly I think we will need to review the need for some of the visibility modifications, some of these methods deliberately were restricted so we could add an enforced security manager check we may need to come up with something else - possibly new permission backed methods etc..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants