[ELY-2104] two calls to introspection endpoint for one request with JWT #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjuma
reviewed
Mar 15, 2021
| private void setClaims(Attributes claims) throws RealmUnavailableException { | ||
| this.claims = claims; | ||
| } | ||
|
|
||
| private Attributes getClaims() throws RealmUnavailableException { | ||
| if (this.claims == null) { | ||
| this.claims = validateToken(this.evidence); |
There was a problem hiding this comment.
Since validateToken now sets the claims value, I think this line can be changed to just validateToken(this.evidence).
fjuma
reviewed
Mar 15, 2021
|
|
||
| return this.claims; | ||
| private Attributes getClaims() throws RealmUnavailableException { | ||
| return validateToken(this.evidence); |
There was a problem hiding this comment.
We'll still need the if statement here in case this.claims is null, i.e.,
if (this.claims == null) {
validateToken(this.evidence);
}
return this.claims;
Just meant that the line this.claims = validateToken(this.evidence); could be simplified to just validateToken(this.evidence);.
There was a problem hiding this comment.
@fjuma Fixed. Thank you
fjuma
approved these changes
Mar 15, 2021
darranl
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ELY-2104