New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ELY-2070] CredentialStore is not able to get data from credential storage in file on IBM JDK 8 #1568
Conversation
@Ashpan Just a minor, I read Ashley's comment linked in this jira that these errors seem to be because IBM JDK is unable to read the ECDSA keys from a credential store. Is there some bug report or maybe release notes from IBM now that mention this which could be linked? |
@Skyllarr I wasn't able to find any specific documentation that IBM has released stating that reading ECSDA keys doesn't work from a credential store, and their bug reporting systems seems to be something for clients/customers not for developers. Although I found this report, but it seems to be for "IBM JCE & JCEPlus providers" which doesn't seem like the issue we are facing. |
@Ashpan The linked issue is probably not this problem since the link says it was fixed in 8.0.5.35, but this bug was originally found for 8.0.6.10 ( #1347 (comment) ). Might be good to double check if the exception happen in isolation as well, so we know for sure it is a bug in IBM and not in our code. |
@Ashpan But actually given this is JDK 8, which is basically deprecated, it is ok to ignore these tests |
@@ -316,6 +316,7 @@ public void testGenerateKeyPairDSA() throws CredentialStoreException { | |||
|
|||
@Test | |||
public void testGenerateKeyPairECDSA() throws CredentialStoreException { | |||
Assume.assumeFalse(IS_IBM); //Don't run if using IBM JDK https://issues.redhat.com/browse/ELY-2070 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ashpan Would you be able to create a new ELY issue for unignoring these tests on IBM JDK and then reference that ELY issue in the comment here and below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…orage in file on IBM JDK 8
https://issues.redhat.com/browse/ELY-2070