[ELY-2149] Enhance logging for silent BASIC authentication mechanism #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, vijay-boddupalli. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment. |
Skyllarr
reviewed
Oct 1, 2021
http/basic/src/main/java/org/wildfly/security/http/basic/BasicAuthenticationMechanism.java
Outdated
Show resolved
Hide resolved
fjuma
reviewed
Oct 1, 2021
| @@ -60,6 +62,7 @@ | |||
|
|
|||
| private final boolean includeCharset; | |||
| private final String configuredRealm; | |||
| private final Logger log = Logger.getLogger(BasicAuthenticationMechanism.class); | |||
There was a problem hiding this comment.
Thanks for the PR, @vijay-boddupalli!
Just a small comment. Instead of adding this logger, you should be able to make use of the httpBasic logger that's used elsewhere in this file, i.e., you should be able to use httpBasic.trace...
Skyllarr
reviewed
Oct 1, 2021
http/basic/src/main/java/org/wildfly/security/http/basic/BasicAuthenticationMechanism.java
Outdated
Show resolved
Hide resolved
Skyllarr
reviewed
Oct 1, 2021
http/basic/src/main/java/org/wildfly/security/http/basic/BasicAuthenticationMechanism.java
Outdated
Show resolved
Hide resolved
vijay-boddupalli
force-pushed
the
ELY2149
branch
from
d11f46e
to
0906f5f
Compare
Added trace log to indicate the BASIC authentication mechanism is ignored when silent is set and AUTHORIZATION header is not present
vijay-boddupalli
force-pushed
the
ELY2149
branch
from
0906f5f
to
ff96721
Compare
Skyllarr
approved these changes
Oct 1, 2021
fjuma
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ELY-2149
Added trace log to indicate the BASIC authentication mechanism is ignored when silent is set and AUTHORIZATION header is not present