[ELY-2161] Add parameter validation to the builder setters in LegacyP… #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjuma
reviewed
Oct 1, 2021
.../realm/base/src/main/java/org/wildfly/security/auth/realm/LegacyPropertiesSecurityRealm.java
Outdated
Show resolved
Hide resolved
|
Hello, vijay-boddupalli. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment. |
fjuma
reviewed
Oct 1, 2021
.../realm/base/src/main/java/org/wildfly/security/auth/realm/LegacyPropertiesSecurityRealm.java
Outdated
Show resolved
Hide resolved
Skyllarr
reviewed
Oct 1, 2021
.../realm/base/src/main/java/org/wildfly/security/auth/realm/LegacyPropertiesSecurityRealm.java
Outdated
Show resolved
Hide resolved
|
@vijay-boddupalli And just a minor suggestion, if you want you can add |
vijay-boddupalli
force-pushed
the
ELY2161
branch
2 times, most recently
from
99e0599
to
900a315
Compare
Skyllarr
reviewed
Oct 1, 2021
.../realm/base/src/main/java/org/wildfly/security/auth/realm/LegacyPropertiesSecurityRealm.java
Outdated
Show resolved
Hide resolved
vijay-boddupalli
force-pushed
the
ELY2161
branch
from
900a315
to
61b0896
Compare
Skyllarr
reviewed
Oct 1, 2021
.../realm/base/src/main/java/org/wildfly/security/auth/realm/LegacyPropertiesSecurityRealm.java
Outdated
Show resolved
Hide resolved
…ropertiesSecurityRealm Added not null validation for setters
vijay-boddupalli
force-pushed
the
ELY2161
branch
from
61b0896
to
b67127f
Compare
Skyllarr
approved these changes
Oct 1, 2021
fjuma
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ELY-2161
Added not null validation for setters