ELY-2271 IdentityCredentials.verify(Supplier<Provider[]>, evidence, h… #1638

tristantarrant · 2021-12-14T21:19:15Z

https://issues.redhat.com/browse/ELY-2271
https://issues.redhat.com/browse/ELY-2272

Please note the deprecations I've added.

wildfly-ci · 2021-12-14T21:22:42Z

Linux - JDK11 EA 28 Build 834 outcome was FAILURE using a merge of 9b9a82d
Summary: Tests failed: 5 (5 new), passed: 568, ignored: 2 Build time: 00:02:34

Failed tests

org.wildfly.security.auth.realm.jdbc.AuthorizationIdentityTest.testValidIdentity: org.wildfly.security.auth.server.RealmUnavailableException: ELY01052: Unexpected error when processing authentication query "SELECT password, firstName, lastName, email FROM user_table WHERE name = ?"
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:244)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.exists(JdbcSecurityRealm.java:189)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getAuthorizationIdentity(JdbcSecurityRealm.java:194)
	at org.wildfly.security.auth.realm.jdbc.AuthorizationIdentityTest.testValidIdentity(AuthorizationIdentityTest.java:77)
	at org.wildfly.security.auth.realm.jdbc.DataSourceRule$1.evaluate(DataSourceRule.java:54)
Caused by: java.lang.RuntimeException: ELY01045: Could not obtain PasswordFactory for algorithm "clear"
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:283)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:234)
	... 4 more
Caused by: java.security.NoSuchAlgorithmException: ELY08028: Invalid algorithm "clear"
	at org.wildfly.security.password.PasswordFactory.getInstance(PasswordFactory.java:123)
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:281)
	... 5 more


org.wildfly.security.auth.realm.jdbc.AttributeMappingTest.testObtainFromDifferentQueriesDifferentTables: org.wildfly.security.auth.server.RealmUnavailableException: ELY01052: Unexpected error when processing authentication query "SELECT password FROM user_table WHERE name = ?"
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:244)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.exists(JdbcSecurityRealm.java:189)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getAuthorizationIdentity(JdbcSecurityRealm.java:194)
	at org.wildfly.security.auth.realm.jdbc.AttributeMappingTest.testObtainFromDifferentQueriesDifferentTables(AttributeMappingTest.java:143)
	at org.wildfly.security.auth.realm.jdbc.DataSourceRule$1.evaluate(DataSourceRule.java:54)
Caused by: java.lang.RuntimeException: ELY01045: Could not obtain PasswordFactory for algorithm "clear"
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:283)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:234)
	... 4 more
Caused by: java.security.NoSuchAlgorithmException: ELY08028: Invalid algorithm "clear"
	at org.wildfly.security.password.PasswordFactory.getInstance(PasswordFactory.java:123)
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:281)
	... 5 more
------- Stderr: -------
Could not load Logmanager "org.jboss.logmanager.LogManager"
java.lang.ClassNotFoundException: org.jboss.logmanager.LogManager
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
	at java.logging/java.util.logging.LogManager$1.run(LogManager.java:239)
	at java.logging/java.util.logging.LogManager$1.run(LogManager.java:223)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.logging/java.util.logging.LogManager.<clinit>(LogManager.java:223)
	at org.jboss.logging.LoggerProviders.tryJBossLogManager(LoggerProviders.java:138)
	at org.jboss.logging.LoggerProviders.findProvider(LoggerProviders.java:79)
	at org.jboss.logging.LoggerProviders.find(LoggerProviders.java:32)
	at org.jboss.logging.LoggerProviders.<clinit>(LoggerProviders.java:29)
	at org.jboss.logging.Logger.getLogger(Logger.java:2465)
	at org.jboss.logging.Logger.doGetMessageLogger(Logger.java:2573)
	at org.jboss.logging.Logger.getMessageLogger(Logger.java:2530)
	at org.jboss.logging.Logger.getMessageLogger(Logger.java:2516)
	at org.wildfly.security.auth.realm.jdbc._private.ElytronMessages.<clinit>(ElytronMessages.java:40)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:210)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.exists(JdbcSecurityRealm.java:189)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getAuthorizationIdentity(JdbcSecurityRealm.java:194)
	at org.wildfly.security.auth.realm.jdbc.AttributeMappingTest.testObtainFromDifferentQueriesDifferentTables(AttributeMappingTest.java:143)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at mockit.integration.junit4.internal.JUnit4TestRunnerDecorator.executeTestMethod(JUnit4TestRunnerDecorator.java:162)
	at mockit.integration.junit4.internal.JUnit4TestRunnerDecorator.invokeExplosively(JUnit4TestRunnerDecorator.java:71)
	at mockit.integration.junit4.internal.MockFrameworkMethod.invokeExplosively(MockFrameworkMethod.java:37)
	at org.wildfly.security.auth.realm.jdbc.DataSourceRule$1.evaluate(DataSourceRule.java:54)


org.wildfly.security.auth.realm.jdbc.AttributeMappingTest.testNoAttributes: org.wildfly.security.auth.server.RealmUnavailableException: ELY01052: Unexpected error when processing authentication query "SELECT password, firstName, lastName, email FROM user_table WHERE name = ?"
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:244)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.exists(JdbcSecurityRealm.java:189)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getAuthorizationIdentity(JdbcSecurityRealm.java:194)
	at org.wildfly.security.auth.realm.jdbc.AttributeMappingTest.testNoAttributes(AttributeMappingTest.java:55)
	at org.wildfly.security.auth.realm.jdbc.DataSourceRule$1.evaluate(DataSourceRule.java:54)
Caused by: java.lang.RuntimeException: ELY01045: Could not obtain PasswordFactory for algorithm "clear"
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:283)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:234)
	... 4 more
Caused by: java.security.NoSuchAlgorithmException: ELY08028: Invalid algorithm "clear"
	at org.wildfly.security.password.PasswordFactory.getInstance(PasswordFactory.java:123)
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:281)
	... 5 more


org.wildfly.security.auth.realm.jdbc.AttributeMappingTest.testObtainFromSingleQuery: org.wildfly.security.auth.server.RealmUnavailableException: ELY01052: Unexpected error when processing authentication query "SELECT password, firstName, lastName, email FROM user_table WHERE name = ?"
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:244)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.exists(JdbcSecurityRealm.java:189)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getAuthorizationIdentity(JdbcSecurityRealm.java:194)
	at org.wildfly.security.auth.realm.jdbc.AttributeMappingTest.testObtainFromSingleQuery(AttributeMappingTest.java:81)
	at org.wildfly.security.auth.realm.jdbc.DataSourceRule$1.evaluate(DataSourceRule.java:54)
Caused by: java.lang.RuntimeException: ELY01045: Could not obtain PasswordFactory for algorithm "clear"
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:283)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:234)
	... 4 more
Caused by: java.security.NoSuchAlgorithmException: ELY08028: Invalid algorithm "clear"
	at org.wildfly.security.password.PasswordFactory.getInstance(PasswordFactory.java:123)
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:281)
	... 5 more


org.wildfly.security.auth.realm.jdbc.AttributeMappingTest.testObtainFromDifferentQueriesSameTable: org.wildfly.security.auth.server.RealmUnavailableException: ELY01052: Unexpected error when processing authentication query "SELECT password FROM user_table WHERE name = ?"
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:244)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.exists(JdbcSecurityRealm.java:189)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getAuthorizationIdentity(JdbcSecurityRealm.java:194)
	at org.wildfly.security.auth.realm.jdbc.AttributeMappingTest.testObtainFromDifferentQueriesSameTable(AttributeMappingTest.java:111)
	at org.wildfly.security.auth.realm.jdbc.DataSourceRule$1.evaluate(DataSourceRule.java:54)
Caused by: java.lang.RuntimeException: ELY01045: Could not obtain PasswordFactory for algorithm "clear"
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:283)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:234)
	... 4 more
Caused by: java.security.NoSuchAlgorithmException: ELY08028: Invalid algorithm "clear"
	at org.wildfly.security.password.PasswordFactory.getInstance(PasswordFactory.java:123)
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:281)
	... 5 more

wildfly-ci · 2021-12-14T21:23:42Z

Windows Build 814 outcome was FAILURE using a merge of 9b9a82d
Summary: Tests failed: 5 (5 new), passed: 568, ignored: 2 Build time: 00:03:33

Failed tests

org.wildfly.security.auth.realm.jdbc.AttributeMappingTest.testObtainFromDifferentQueriesDifferentTables: org.wildfly.security.auth.server.RealmUnavailableException: ELY01052: Unexpected error when processing authentication query "SELECT password FROM user_table WHERE name = ?"
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:244)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.exists(JdbcSecurityRealm.java:189)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getAuthorizationIdentity(JdbcSecurityRealm.java:194)
	at org.wildfly.security.auth.realm.jdbc.AttributeMappingTest.testObtainFromDifferentQueriesDifferentTables(AttributeMappingTest.java:143)
	at org.wildfly.security.auth.realm.jdbc.DataSourceRule$1.evaluate(DataSourceRule.java:54)
Caused by: java.lang.RuntimeException: ELY01045: Could not obtain PasswordFactory for algorithm "clear"
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:283)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:234)
	... 4 more
Caused by: java.security.NoSuchAlgorithmException: ELY08028: Invalid algorithm "clear"
	at org.wildfly.security.password.PasswordFactory.getInstance(PasswordFactory.java:123)
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:281)
	... 5 more
------- Stderr: -------
Could not load Logmanager "org.jboss.logmanager.LogManager"
java.lang.ClassNotFoundException: org.jboss.logmanager.LogManager
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
	at java.logging/java.util.logging.LogManager$1.run(LogManager.java:239)
	at java.logging/java.util.logging.LogManager$1.run(LogManager.java:223)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.logging/java.util.logging.LogManager.<clinit>(LogManager.java:223)
	at org.jboss.logging.LoggerProviders.tryJBossLogManager(LoggerProviders.java:138)
	at org.jboss.logging.LoggerProviders.findProvider(LoggerProviders.java:79)
	at org.jboss.logging.LoggerProviders.find(LoggerProviders.java:32)
	at org.jboss.logging.LoggerProviders.<clinit>(LoggerProviders.java:29)
	at org.jboss.logging.Logger.getLogger(Logger.java:2465)
	at org.jboss.logging.Logger.doGetMessageLogger(Logger.java:2573)
	at org.jboss.logging.Logger.getMessageLogger(Logger.java:2530)
	at org.jboss.logging.Logger.getMessageLogger(Logger.java:2516)
	at org.wildfly.security.auth.realm.jdbc._private.ElytronMessages.<clinit>(ElytronMessages.java:40)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:210)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.exists(JdbcSecurityRealm.java:189)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getAuthorizationIdentity(JdbcSecurityRealm.java:194)
	at org.wildfly.security.auth.realm.jdbc.AttributeMappingTest.testObtainFromDifferentQueriesDifferentTables(AttributeMappingTest.java:143)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at mockit.integration.junit4.internal.JUnit4TestRunnerDecorator.executeTestMethod(JUnit4TestRunnerDecorator.java:162)
	at mockit.integration.junit4.internal.JUnit4TestRunnerDecorator.invokeExplosively(JUnit4TestRunnerDecorator.java:71)
	at mockit.integration.junit4.internal.MockFrameworkMethod.invokeExplosively(MockFrameworkMethod.java:37)
	at org.wildfly.security.auth.realm.jdbc.DataSourceRule$1.evaluate(DataSourceRule.java:54)


org.wildfly.security.auth.realm.jdbc.AttributeMappingTest.testNoAttributes: org.wildfly.security.auth.server.RealmUnavailableException: ELY01052: Unexpected error when processing authentication query "SELECT password, firstName, lastName, email FROM user_table WHERE name = ?"
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:244)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.exists(JdbcSecurityRealm.java:189)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getAuthorizationIdentity(JdbcSecurityRealm.java:194)
	at org.wildfly.security.auth.realm.jdbc.AttributeMappingTest.testNoAttributes(AttributeMappingTest.java:55)
	at org.wildfly.security.auth.realm.jdbc.DataSourceRule$1.evaluate(DataSourceRule.java:54)
Caused by: java.lang.RuntimeException: ELY01045: Could not obtain PasswordFactory for algorithm "clear"
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:283)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:234)
	... 4 more
Caused by: java.security.NoSuchAlgorithmException: ELY08028: Invalid algorithm "clear"
	at org.wildfly.security.password.PasswordFactory.getInstance(PasswordFactory.java:123)
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:281)
	... 5 more


org.wildfly.security.auth.realm.jdbc.AttributeMappingTest.testObtainFromSingleQuery: org.wildfly.security.auth.server.RealmUnavailableException: ELY01052: Unexpected error when processing authentication query "SELECT password, firstName, lastName, email FROM user_table WHERE name = ?"
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:244)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.exists(JdbcSecurityRealm.java:189)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getAuthorizationIdentity(JdbcSecurityRealm.java:194)
	at org.wildfly.security.auth.realm.jdbc.AttributeMappingTest.testObtainFromSingleQuery(AttributeMappingTest.java:81)
	at org.wildfly.security.auth.realm.jdbc.DataSourceRule$1.evaluate(DataSourceRule.java:54)
Caused by: java.lang.RuntimeException: ELY01045: Could not obtain PasswordFactory for algorithm "clear"
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:283)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:234)
	... 4 more
Caused by: java.security.NoSuchAlgorithmException: ELY08028: Invalid algorithm "clear"
	at org.wildfly.security.password.PasswordFactory.getInstance(PasswordFactory.java:123)
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:281)
	... 5 more


org.wildfly.security.auth.realm.jdbc.AttributeMappingTest.testObtainFromDifferentQueriesSameTable: org.wildfly.security.auth.server.RealmUnavailableException: ELY01052: Unexpected error when processing authentication query "SELECT password FROM user_table WHERE name = ?"
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:244)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.exists(JdbcSecurityRealm.java:189)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getAuthorizationIdentity(JdbcSecurityRealm.java:194)
	at org.wildfly.security.auth.realm.jdbc.AttributeMappingTest.testObtainFromDifferentQueriesSameTable(AttributeMappingTest.java:111)
	at org.wildfly.security.auth.realm.jdbc.DataSourceRule$1.evaluate(DataSourceRule.java:54)
Caused by: java.lang.RuntimeException: ELY01045: Could not obtain PasswordFactory for algorithm "clear"
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:283)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:234)
	... 4 more
Caused by: java.security.NoSuchAlgorithmException: ELY08028: Invalid algorithm "clear"
	at org.wildfly.security.password.PasswordFactory.getInstance(PasswordFactory.java:123)
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:281)
	... 5 more


org.wildfly.security.auth.realm.jdbc.AuthorizationIdentityTest.testValidIdentity: org.wildfly.security.auth.server.RealmUnavailableException: ELY01052: Unexpected error when processing authentication query "SELECT password, firstName, lastName, email FROM user_table WHERE name = ?"
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:244)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.exists(JdbcSecurityRealm.java:189)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getAuthorizationIdentity(JdbcSecurityRealm.java:194)
	at org.wildfly.security.auth.realm.jdbc.AuthorizationIdentityTest.testValidIdentity(AuthorizationIdentityTest.java:77)
	at org.wildfly.security.auth.realm.jdbc.DataSourceRule$1.evaluate(DataSourceRule.java:54)
Caused by: java.lang.RuntimeException: ELY01045: Could not obtain PasswordFactory for algorithm "clear"
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:283)
	at org.wildfly.security.auth.realm.jdbc.JdbcSecurityRealm$JdbcRealmIdentity.getIdentity(JdbcSecurityRealm.java:234)
	... 4 more
Caused by: java.security.NoSuchAlgorithmException: ELY08028: Invalid algorithm "clear"
	at org.wildfly.security.password.PasswordFactory.getInstance(PasswordFactory.java:123)
	at org.wildfly.security.auth.realm.jdbc.mapper.PasswordKeyMapper.map(PasswordKeyMapper.java:281)
	... 5 more

wildfly-ci · 2021-12-14T21:32:27Z

Linux - JDK11 EA 28 Build 835 outcome was FAILURE using a merge of 0daff58
Summary: Tests passed: 573, ignored: 2; exit code 1 (Step: Maven) Build time: 00:02:32

wildfly-ci · 2021-12-14T21:33:29Z

Windows Build 815 outcome was FAILURE using a merge of 0daff58
Summary: Tests passed: 573, ignored: 2; exit code 1 (Step: Maven) Build time: 00:03:33

wildfly-ci · 2021-12-14T21:57:23Z

Linux - JDK11 EA 28 Build 836 outcome was FAILURE using a merge of 041ce47
Summary: Tests passed: 573, ignored: 2; exit code 1 (Step: Maven) Build time: 00:02:26

wildfly-ci · 2021-12-14T21:58:27Z

Windows Build 816 outcome was FAILURE using a merge of 041ce47
Summary: Tests passed: 573, ignored: 2; exit code 1 (Step: Maven) Build time: 00:03:31

fjuma · 2021-12-15T22:24:08Z

...realm/base/src/main/java/org/wildfly/security/auth/realm/CachingModifiableSecurityRealm.java

+    /**
+     * Creates a new instance.
+     *
+     * @param realm the {@link CacheableSecurityRealm} whose {@link RealmIdentity} should be cached..


Just a small comment, there's an extra period at the end of this line

FIxed this one and the one above

fjuma · 2021-12-15T22:27:15Z

http/basic/src/main/java/org/wildfly/security/http/basic/BasicMechanismFactory.java

@@ -45,7 +45,7 @@
    public BasicMechanismFactory() {
    }

-    public BasicMechanismFactory(final Provider provider) {
+    public BasicMechanismFactory(final Provider... providers) {


Just FYI for other reviewers, this isn't public API.

fjuma · 2021-12-15T22:31:49Z

@tristantarrant This looks good to me. Just noticed, this PR was submitted against the 1.x branch. If you'd like to get this fix into 1.17.x, you can update this to be directly against that branch. We then forward port to 1.x as part of our release process.

* Deprecate methods which use the installed providers

fjuma · 2021-12-16T15:24:36Z

Thanks, @tristantarrant! I've now created the 1.17.x branch. If you could update this PR to be based off that branch that would be great. (I tried changing the base branch myself but more work is needed.)

tristantarrant · 2021-12-16T15:31:11Z

1.17 backport: #1641

fjuma · 2021-12-16T15:38:01Z

Perfect, thanks @tristantarrant! I'm going to close this one now in favour of #1641. We forward port the changes from maintenance branches to 1.x as part of our release process so we don't need the additional PR.

tristantarrant force-pushed the ELY-2271 branch from 0daff58 to 041ce47 Compare December 14, 2021 21:53

tristantarrant force-pushed the ELY-2271 branch 2 times, most recently from 18d0c1a to 4c80b6f Compare December 15, 2021 09:48

fjuma approved these changes Dec 15, 2021

View reviewed changes

fjuma added the +1 FJ label Dec 15, 2021

tristantarrant force-pushed the ELY-2271 branch from 4c80b6f to f8f3190 Compare December 16, 2021 07:49

tristantarrant added 2 commits December 16, 2021 08:49

ELY-2271 Ensure supplied Providers are used throughout

c1f7fff

* Deprecate methods which use the installed providers

ELY-2272 Ensure tests work without registering JVM Security providers

92a87ff

tristantarrant force-pushed the ELY-2271 branch from f8f3190 to 92a87ff Compare December 16, 2021 07:49

fjuma changed the base branch from 1.x to 1.17.x December 16, 2021 15:23

fjuma changed the base branch from 1.17.x to 1.x December 16, 2021 15:23

fjuma closed this Dec 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ELY-2271 IdentityCredentials.verify(Supplier<Provider[]>, evidence, h… #1638

ELY-2271 IdentityCredentials.verify(Supplier<Provider[]>, evidence, h… #1638

tristantarrant commented Dec 14, 2021 •

edited

wildfly-ci commented Dec 14, 2021

wildfly-ci commented Dec 14, 2021

wildfly-ci commented Dec 14, 2021

wildfly-ci commented Dec 14, 2021

wildfly-ci commented Dec 14, 2021

wildfly-ci commented Dec 14, 2021

fjuma Dec 15, 2021

tristantarrant Dec 16, 2021

fjuma Dec 15, 2021

fjuma commented Dec 15, 2021

fjuma commented Dec 16, 2021

tristantarrant commented Dec 16, 2021

fjuma commented Dec 16, 2021

ELY-2271 IdentityCredentials.verify(Supplier<Provider[]>, evidence, h… #1638

ELY-2271 IdentityCredentials.verify(Supplier<Provider[]>, evidence, h… #1638

Conversation

tristantarrant commented Dec 14, 2021 • edited

wildfly-ci commented Dec 14, 2021

Failed tests

wildfly-ci commented Dec 14, 2021

Failed tests

wildfly-ci commented Dec 14, 2021

wildfly-ci commented Dec 14, 2021

wildfly-ci commented Dec 14, 2021

wildfly-ci commented Dec 14, 2021

fjuma Dec 15, 2021

Choose a reason for hiding this comment

tristantarrant Dec 16, 2021

Choose a reason for hiding this comment

fjuma Dec 15, 2021

Choose a reason for hiding this comment

fjuma commented Dec 15, 2021

fjuma commented Dec 16, 2021

tristantarrant commented Dec 16, 2021

fjuma commented Dec 16, 2021

tristantarrant commented Dec 14, 2021 •

edited