Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELY-2297 Wrong path for Setup the JBoss Maven Repository. #1666

Merged
merged 1 commit into from Mar 18, 2022
Merged

ELY-2297 Wrong path for Setup the JBoss Maven Repository. #1666

merged 1 commit into from Mar 18, 2022

Conversation

RanabirChakraborty
Copy link
Contributor

Skyllarr
Skyllarr reviewed Jan 24, 2022
View reviewed changes
README.md Outdated
@@ -15,7 +15,7 @@ $ git clone git@github.com:wildfly-security/wildfly-elytron.git
Setup the JBoss Maven Repository
--------------------------------

To use dependencies from JBoss.org, you need to add the JBoss Maven Repositories to your Maven settings.xml. For details see http://community.jboss.org/wiki/MavenGettingStarted-Users
To use dependencies from JBoss.org, you need to add the JBoss Maven Repositories to your Maven settings.xml. For details see [MavenGettingStarted-Users](https://developer.jboss.org/docs/DOC-15169)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RanabirChakraborty Thanks for the PR! You can use spaces in [MavenGettingStarted-Users] for readability.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! did the changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Skyllarr Skyllarr added the +1 DV label Feb 21, 2022
fjuma
fjuma approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RanabirChakraborty!

@fjuma fjuma merged commit 0c014dd into wildfly-security:1.x Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skyllarr Skyllarr Skyllarr approved these changes

@fjuma fjuma fjuma approved these changes

Assignees
No one assigned
Labels
+1 DV
Projects
None yet
Milestone
No milestone
3 participants
@RanabirChakraborty @fjuma @Skyllarr