[ELY-2304] Location is required even for non-filebased type e.g. PKCS11 #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skyllarr
approved these changes
Feb 21, 2022
fjuma
approved these changes
Apr 5, 2022
|
@rmartinc Can you please rebase to re-trigger the CI ? Thanks! |
|
@Skyllarr Done! And tests passed OK! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/ELY-2304
Little check for the
locationbefore saving/restoring its file permissions. JCEKS, PKCS12 or JKS types require a location and that condition is checked previously. Soat this point
locationcan happen to benullif the type does not require it (PKCS11 is an example).