[ELY-2310] Enhance DigestAuthenticationMechanismTest to compute digest values instead of using hard coded values #1685
Conversation
|
Hello @miador . Thank you for PR! Pls change your commit title to have the issue number at the beginning, Thanks! |
| import static org.wildfly.security.http.HttpConstants.SHA256; | ||
| import static org.wildfly.security.http.HttpConstants.SHA512_256; | ||
| import static org.wildfly.security.http.HttpConstants.UNAUTHORIZED; | ||
| import static org.wildfly.security.http.HttpConstants.*; |
There was a problem hiding this comment.
Just minor, please do not use * in imports
| @@ -19,7 +19,6 @@ | |||
| package org.wildfly.security.http.digest; | |||
|
|
|||
| import mockit.integration.junit4.JMockit; | |||
|
|
|||
There was a problem hiding this comment.
@miador Just minor, this space should be added back
| } | ||
|
|
||
| @Test | ||
| public void testRfc2617EncodedQuery() throws Exception { |
There was a problem hiding this comment.
@miador Why is this test method removed?
There was a problem hiding this comment.
Oh sorry. Adding back
| " opaque=\"00000000000000000000000000000000\",\n" + | ||
| " algorithm=MD5" | ||
| }, new URI(uri)); |
There was a problem hiding this comment.
@miador testRfc2617EncodedPath test method was removed, maybe you need to rebase on 1.x?
…t values instead of using hard coded values
|
The |
@miador Currently some tests use uppercase |
|
Hello, |
|
@fjuma Please review |
Trying to solve https://issues.redhat.com/browse/ELY-2310
According to spec, the A1 value should be
unq(username) ":" unq(realm) ":" passwd. I've refactored the A1 according to that and since no password needed inencodei removed if block.