Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELY-2396] Update string to int conversion in ModularCrypt #1753

Merged
merged 1 commit into from
Oct 7, 2022
Merged

[ELY-2396] Update string to int conversion in ModularCrypt #1753

merged 1 commit into from
Oct 7, 2022

Conversation

Kshitiz-Mhto
Copy link
Contributor

issue: ELY-2396

@fjuma
Copy link
Contributor

fjuma commented Sep 17, 2022

@Kshitiz-Mhto Thanks again for your PRs last week! We'll make sure we get you feedback on these next week.

(cc @Skyllarr)

@Skyllarr
Copy link
Contributor

Skyllarr commented Sep 26, 2022 •
edited

@Kshitiz-Mhto Thank you! I have approved. This just needs an approve from a second person and it can be merged

@Skyllarr Skyllarr added the +1 DV label Sep 26, 2022
fjuma
fjuma approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kshitiz-Mhto!

By the way, if you're interested, WildFly Elytron is participating in Hacktoberfest this month (all the details can be found here).

@fjuma fjuma merged commit 16b9726 into wildfly-security:1.x Oct 7, 2022
@fjuma fjuma added the +1 FJ label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjuma fjuma fjuma approved these changes

@Skyllarr Skyllarr Skyllarr approved these changes

Assignees
No one assigned
Labels
+1 DV +1 FJ
Projects
None yet
Milestone
No milestone
3 participants
@Kshitiz-Mhto @fjuma @Skyllarr