[ELY-2446] Add a test class for RegexNameRewriter #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skyllarr
reviewed
Sep 16, 2022
| Pattern pattern = Pattern.compile("\\."); | ||
|
|
||
| RegexNameRewriter regexNameRewriter = new RegexNameRewriter(pattern, "dot", true); | ||
| MutableNameRewriter rewriter = new MutableNameRewriter(regexNameRewriter); |
There was a problem hiding this comment.
@mittalaishwarya You don't need to use MutableNameRewriter at all to test RegexNameRewriter. You can just call method rewriteName on the regexNameRewriter
Skyllarr
reviewed
Sep 16, 2022
| package org.wildfly.security.auth.util; | ||
|
|
||
| import org.junit.Test; | ||
| import org.wildfly.security.auth.util.RegexNameRewriter; |
There was a problem hiding this comment.
@mittalaishwarya Just a minor, this class is in the same package as this test. So you don't have to import it
|
@mittalaishwarya Otherwise this looks good! |
|
Hey, if you could squash these changes into one commit, that would be awesome. Thanks! |
mittalaishwarya
force-pushed
the
ELY-2446
branch
from
672110b
to
3bb1838
Compare
Skyllarr
approved these changes
Sep 29, 2022
|
@mittalaishwarya Looks great, thank you! |
fjuma
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Sorry for the delay in getting this one merged, I've been away for a bit.
Thanks very much @mittalaishwarya!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ELY-2446