[ELY-2475] Use the primitive boolean expression in DelegatingAuthConfigFactory #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mittalaishwarya
force-pushed
the
ELY-2475
branch
from
edd3985
to
51a87f3
Compare
fjuma
reviewed
Oct 25, 2022
| @@ -53,7 +53,7 @@ public DelegatingAuthConfigFactory(final ElytronAuthConfigFactory elytronAuthCon | |||
| @Override | |||
| public AuthConfigProvider getConfigProvider(String layer, String appContext, RegistrationListener listener) { | |||
| AuthConfigProvider authConfigProvider = elytronAuthConfigFactory.getConfigProvider(layer, appContext, listener); | |||
| if (authConfigProvider != null || elytronAuthConfigFactory.matchesRegistration(layer, appContext) || !delegationAllowed.get()) { | |||
| if (authConfigProvider != null || elytronAuthConfigFactory.matchesRegistration(layer, appContext) || Boolean.TRUE.equals(delegationAllowed.get())) { | |||
There was a problem hiding this comment.
Because the original condition was !delegationAllowed.get(), this should be updated to either:
!Boolean.TRUE.equals(delegationAllowed.get())
or more directly:
Boolean.FALSE.equals(delegationAllowed.get()).
mittalaishwarya
force-pushed
the
ELY-2475
branch
from
70522b2
to
1b93f8a
Compare
mittalaishwarya
force-pushed
the
ELY-2475
branch
from
31332c1
to
48bd5fe
Compare
fjuma
requested changes
Oct 31, 2022
There was a problem hiding this comment.
@mittalaishwarya Looks like something went wrong with the rebase here, this PR now contains some extra changes. Let us know if you need any helping getting this fixed.
|
Hi @mittalaishwarya, feel free to let us know if you need any help updating this PR, thanks! |
|
Closing this since it was superseded by #1876. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ELY-2475