-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ELY-2536] Tool encrypt command creates invalid CLI script for bulk conversion #1892
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good, thanks @lvydra!
@Skyllarr Please review on Monday, thanks! |
@Test | ||
public void testBulkWithoutNames() throws Exception { | ||
String descriptorFileLocation = "./target/test-classes/bulk-encryption-conversion-desc-without-names"; | ||
runCommand(descriptorFileLocation, 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lvydra Looks good! Just a question, the resulting CLI file should be deleted after the test. Can we add a afterclass method to do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving to not hold this fix. The deletion of generated files can be handled as a subsequent issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lvydra!
https://issues.redhat.com/browse/ELY-2536