[ELY-2693] Unit test code refactor (removed duplicates) #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjuma
requested changes
Oct 23, 2023
There was a problem hiding this comment.
Thanks @sugan0tech, this looks good, I've only added a small comment.
If you could also update the title and commit message to add details about the specific test class that is being updated (similar to my comment in the other PR), that would also be good.
Thanks!
tests/base/src/test/java/org/wildfly/security/auth/realm/token/JwtSecurityRealmTest.java
Outdated
Show resolved
Hide resolved
sugan0tech
force-pushed
the
sugan0tech/ELY-2693
branch
from
bf3530d
to
6bb04a9
Compare
…r method for tests with similar use of SSLContext and securityRealm
sugan0tech
force-pushed
the
sugan0tech/ELY-2693
branch
from
6bb04a9
to
0ddf317
Compare
fjuma
approved these changes
Oct 25, 2023
Skyllarr
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ELY-2693