Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELY-2667] Upgrade org.jboss.logging:jboss-logging from 3.4.3.Final to 3.5.3.Final #2051

Merged
merged 1 commit into from
Oct 31, 2023
Merged

[ELY-2667] Upgrade org.jboss.logging:jboss-logging from 3.4.3.Final to 3.5.3.Final #2051

merged 1 commit into from
Oct 31, 2023

Conversation

Iscar-daniel
Copy link
Contributor

[ELY-2667] Upgrade org.jboss.logging:jboss-logging from 3.4.3.Final to 3.5.3.Final
https://issues.redhat.com/browse/ELY-2667?filter=12364234

@Skyllarr
Copy link
Contributor

HI @Iscar-daniel , please update the commit message to contain the issue number ELY-2667 at the beginning. Thank you!

@Iscar-daniel Iscar-daniel force-pushed the ELY-2667 branch 2 times, most recently from d8f8b49 to a547f61 Compare October 27, 2023 17:55
Skyllarr
Skyllarr approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Skyllarr Skyllarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Iscar-daniel !

@PrarthonaPaul
Copy link
Contributor

Hi @Iscar-daniel
It seems like the commit message has an extra ELY-2667] Upgrade org.jboss.logging:jboss-logging from 3.4.3.Final to 3.5.3.Final https://issues.redhat.com/browse/ELY-2667?filter=12364234 added to it. Could you please edit the commit message to fix it? Also, this is minor, but could you also add the [ to the beginning of the commit message? Thanks

@Iscar-daniel
Copy link
Contributor Author

Iscar-daniel commented Oct 31, 2023 •
edited
Loading

Hi @Iscar-daniel It seems like the commit message has an extra ELY-2667] Upgrade org.jboss.logging:jboss-logging from 3.4.3.Final to 3.5.3.Final https://issues.redhat.com/browse/ELY-2667?filter=12364234 added to it. Could you please edit the commit message to fix it? Also, this is minor, but could you also add the [ to the beginning of the commit message? Thanks

i see, i just added the summary is that ok? the '[' character is added

fjuma
fjuma approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Iscar-daniel and welcome to the WildFly Elytron project!

@fjuma fjuma merged commit c8f40d8 into wildfly-security:2.x Oct 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjuma fjuma fjuma approved these changes

@Skyllarr Skyllarr Skyllarr approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted +1 DV
Projects
None yet
Milestone
No milestone
4 participants
@Iscar-daniel @Skyllarr @PrarthonaPaul @fjuma