Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELY-254] - Improvements to FileSystemRealm regarding XML writing and namespace validation. #262

Merged
merged 2 commits into from Aug 5, 2015

Conversation

pedroigor
Copy link
Contributor

References

Overview

When testing the filesystem realm using a running Wildfly instance, I've found some errors when reading attributes.
The error is related with the namespace validation, which must be changed in order to also consider empty namespaces.
Also, we can improve how the document and start elements are written and avoid specify the namespace all the time.
Basically, I've considered the same logic from Wildfly Core regarding how both XMLStreamReader and XMLStreamWriter are being used.

@wildfly-ci
Copy link

Windows Build 693 is now running using a merge of 39f2f8b

@wildfly-ci
Copy link

Linux Build 687 is now running using a merge of 39f2f8b

@wildfly-ci
Copy link

Linux Build 687 outcome was SUCCESS using a merge of 39f2f8b
Summary: Tests passed: 580, ignored: 3 Build time: 0:01:52

@wildfly-ci
Copy link

Windows Build 693 outcome was SUCCESS using a merge of 39f2f8b
Summary: Tests passed: 580, ignored: 3 Build time: 0:02:29

@darranl
Copy link
Contributor

darranl commented Aug 5, 2015

It should not be a problem to any parser if we duplicate the namespace in a child element, where we should have a problem is if there is an attempt to change to a different version.

Having said that I am assuming this is still uses a namespace at the top level so overall this file is still versioned.

@pedroigor
Copy link
Contributor Author

Yeah, sure. The namespace is already defined at the top level.

@wildfly-ci
Copy link

Windows Build 696 is now running using a merge of ce4dc1c

@wildfly-ci
Copy link

Linux Build 690 is now running using a merge of ce4dc1c

@wildfly-ci
Copy link

Linux Build 690 outcome was SUCCESS using a merge of ce4dc1c
Summary: Tests passed: 580, ignored: 3 Build time: 0:01:46

@wildfly-ci
Copy link

Windows Build 696 outcome was SUCCESS using a merge of ce4dc1c
Summary: Tests passed: 580, ignored: 3 Build time: 0:02:15

@darranl darranl added the +1 DAL label Aug 5, 2015
@fjuma fjuma added the +1 FJ label Aug 5, 2015
fjuma added a commit that referenced this pull request Aug 5, 2015
[ELY-254] - Improvements to FileSystemRealm regarding XML writing and namespace validation.
@fjuma fjuma merged commit fa10c15 into wildfly-security:master Aug 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants