[ELY-345] Enhancements to the getCredential API on the realm identities. #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lve the full credential name list against the Map of supported credential types with their supported algorithms. At the same time the getCredential method that realms are required to implement on their identity is reduced down to the most basic: - Credential getCredential(String credentialName); Realms can then optionally choose to implement the stronger variants if they make sense to the realm, otherwise default implementations are provided.
pedroigor
added a commit
that referenced
this pull request
Oct 26, 2015
[ELY-345] Enhancements to the getCredential API on the realm identities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow getCredential on the RealmIdentity to be able to reso…lve the full credential name list against the Map of supported credential types with their supported algorithms.
At the same time the getCredential method that realms are required to implement on their identity is reduced down to the most basic: -
Credential getCredential(String credentialName);
Realms can then optionally choose to implement the stronger variants if they make sense to the realm, otherwise default implementations are provided.