GSSAPI tests and fixes #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed AbstractGssapiMechanism.DEFAULT_MAX_BUFFER_SIZE (3 octets) * Fixed bugs in networkOrderBytesToInt() and intToNetworkOrderBytes() * ChallengeResponseState should return byte[0] instead of null * SecurityLayerAdvertiser: gssContext.getWrapSizeLimit() moved on the opposite side of communication * getNegotiatedProperty now returns Strings * Allowed disabling of mutual authentication by client props
| gssContext.requestMutualAuth(true); | ||
| } | ||
| boolean requestMutualAuth = serverAuth || mayRequireSecurityLayer; | ||
| log.trace("Setting requering mutual authentication to "+Boolean.toString(requestMutualAuth)); |
There was a problem hiding this comment.
Sorry missed this one, this needs to be a tracef call otherwise we have a redundant String concatenation.
|
I will go ahead and merge, I will add a commit myself for the two comments I just added. |
darranl
added a commit
that referenced
this pull request
Oct 7, 2014
|
Merged |
fjuma
added a commit
to fjuma/wildfly-elytron
that referenced
this pull request
Dec 14, 2018
[ELY-1711] Create a new 'wildfly-elytron-auth-util' module.
darranl
pushed a commit
to darranl-archive/2020-wildfly-elytron
that referenced
this pull request
Jan 7, 2019
[ELY-1043] PicketBox Vault 2.0 conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in production code:
AbstractGssapiMechanism.DEFAULT_MAX_BUFFER_SIZE(3 octets)networkOrderBytesToInt(),intToNetworkOrderBytes()andparsePreferredQop()byte[0]instead ofnullgssContext.getWrapSizeLimit()moved on theopposite side of communication