Extended Digest-MD5 and moved into md5digest package #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaarok
commented
Oct 5, 2014
thaarok
commented
- Tests of Digest-MD5 now tests unwrapping with non-correct messages.
- All Digest-MD5 tests was moved into package org.wildfly.security.sasl.md5digest
- Because it was ClientCallbackHandler and ServerCallbackHandler made public to be accesible from other test packages. (It could be used in more SASL mechanism tests like SCRAM or Gssapi)
added 2 commits
October 5, 2014 16:53
made public (moved tests not changed)
|
Dont merge for now, I will add small refactoring and Peter merge it into his branch. |
|
As I commented on Peters PR it will be nice if overall we can eliminate the MD5 from the package and mechanism name to give us the option to be using this with alternative hash algorithms. I will need to dig out the IETF drafts but every now and again there are proposals to just support alternative algorithms, as we are in general supplying the client and server side libraries that is something I think we need to be considering. |
|
@darranl , IMO we can merge this change as tests are Digest MD5 specific, so new package name for tests is fine. |
|
Merged |
darranl
added a commit
to darranl-archive/2020-wildfly-elytron
that referenced
this pull request
Dec 14, 2018
[ELY-1711] Split out 'org.wildfly.security.mechanism'
darranl
pushed a commit
to darranl-archive/2020-wildfly-elytron
that referenced
this pull request
Jan 7, 2019
[ELY-1089] CS tool, missing parameters compared to management API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.