-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ELY-704] Create PBE utility for use in elytron and tooling #531
Conversation
Linux Build 1188 outcome was FAILURE using a merge of c2c164b Failed tests
|
Windows Build 1193 outcome was FAILURE using a merge of c2c164b Failed tests
|
private String encodedIV; | ||
private AlgorithmParameters algorithmParameters; | ||
|
||
Builder password(char[] initialKeyAsChars) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These methods probably should be public.
private final AlgorithmParameters algorithmParameters; | ||
private final Alphabet alphabet; | ||
|
||
private PasswordBasedEncryptionUtil(Cipher cipher, AlgorithmParameters algorithmParameters, Alphabet alphabet) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any time you have a constructor or method which is private but called from a nested or enclosing class, the compiler has to produce a "fake" member with package-private access which calls the private member. Sometimes this process goes awry. Therefore it's usually better to make such members be package-private in the first place instead of private.
Changes suggested by @dmlloyd incorporated. |
this PR adds PBE utility for use with tooling and credential stores. It provides compatibility with older code used in PicketBox.
https://issues.jboss.org/browse/ELY-704