[ELY-734] Don't report an error if there is no peer cerificate, instead report no authentication in progress and return. #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad report no authentication in progress and return. This allows other configured mechanisms an opportunity to authenticate.
dmlloyd
reviewed
Nov 10, 2016
| throw log.mechCallbackHandlerFailedForUnknownReason(CLIENT_CERT_NAME, e).toHttpAuthenticationException(); | ||
| log.trace("CLIENT-CERT Peer Unverified"); | ||
| request.noAuthenticationInProgress(); | ||
| return true; |
There was a problem hiding this comment.
Don't you have to do something to establish the anonymous identity then?
There was a problem hiding this comment.
No this is just the mechanism, the outer HTTP framework handles this.
This is where each mechanism is given an opportunity to authenticate if it can based on the information it has to hand, if non succeed the outer framework will then decide if we have to challenge or prevent access.
We need each mechanism that can't authenticate to do nothing this way to give the next in the chain the opportunity to do something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows other configured mechanisms an opportunity to authenticate.