[ELY-762] Move SaslClientFactory handling to AuthenticationConfiguration #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Remoting side of the changes are here jboss-remoting/jboss-remoting#84 |
dmlloyd
reviewed
Nov 17, 2016
| private final Supplier<SaslClientFactory> saslClientFactorySupplier; | ||
|
|
||
| SetSaslClientFactoryAuthenticationConfiguration(final AuthenticationConfiguration parent, final Supplier<SaslClientFactory> saslClientFactorySupplier) { | ||
| super(parent.without(SetSaslClientFactoryAuthenticationConfiguration.class)); |
There was a problem hiding this comment.
The "without" here is redundant as the base class already ensures the same class doesn't exist on the chain.
|
Otherwise looks OK. |
|
See http://lists.jboss.org/pipermail/wildfly-dev/2016-November/005545.html - it's generally not a good practice to have "bad" commits with subsequent "fix" commits, because it leaves wrong code in the upstream history, makes bisect less likely to work, etc. |
…ntations are not supposed to be overriding these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.