[ELY-908] Fixed LegacyPropertiesSecurityRealmTest

[olukas]

https://issues.jboss.org/browse/ELY-908

Fixed wrong encoding of specialchars.properties

[wildfly-ci]

Linux Build 1454 outcome was FAILURE using a merge of ac45e2b
Summary: Tests failed: 1 (1 new), passed: 802, ignored: 18 Build time: 00:02:16

Failed tests

org.wildfly.security.credential.store.impl.KeyStoreCredentialStoreTest.shouldSupportKeyStoreFormat[format=PKCS12]: org.wildfly.security.credential.store.CredentialStoreException: ELY09516: Cannot acquire a credential from the credential store
	at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore.retrieve(KeyStoreCredentialStore.java:401)
	at org.wildfly.security.credential.store.impl.KeyStoreCredentialStoreTest.shouldSupportKeyStoreFormat(KeyStoreCredentialStoreTest.java:127)
Caused by: java.security.UnrecoverableKeyException: Get Key failed: 1.2.840.113549.1.7.1 SecretKeyFactory not available
	at sun.security.pkcs12.PKCS12KeyStore.engineGetKey(PKCS12KeyStore.java:410)
	at sun.security.pkcs12.PKCS12KeyStore.engineGetEntry(PKCS12KeyStore.java:1282)
	at java.security.KeyStore.getEntry(KeyStore.java:1521)
	at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore.retrieve(KeyStoreCredentialStore.java:399)
	... 37 more
Caused by: java.security.NoSuchAlgorithmException: 1.2.840.113549.1.7.1 SecretKeyFactory not available
	at javax.crypto.SecretKeyFactory.<init>(SecretKeyFactory.java:122)
	at javax.crypto.SecretKeyFactory.getInstance(SecretKeyFactory.java:160)
	at sun.security.pkcs12.PKCS12KeyStore.engineGetKey(PKCS12KeyStore.java:387)
	... 40 more

[wildfly-ci]

Windows Build 1450 outcome was FAILURE using a merge of ac45e2b
Summary: Tests failed: 1 (1 new), passed: 802, ignored: 18 Build time: 00:03:31

Failed tests

org.wildfly.security.credential.store.impl.KeyStoreCredentialStoreTest.shouldSupportKeyStoreFormat[format=PKCS12]: org.wildfly.security.credential.store.CredentialStoreException: ELY09516: Cannot acquire a credential from the credential store
	at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore.retrieve(KeyStoreCredentialStore.java:401)
	at org.wildfly.security.credential.store.impl.KeyStoreCredentialStoreTest.shouldSupportKeyStoreFormat(KeyStoreCredentialStoreTest.java:127)
Caused by: java.security.UnrecoverableKeyException: Get Key failed: 1.2.840.113549.1.7.1 SecretKeyFactory not available
	at sun.security.pkcs12.PKCS12KeyStore.engineGetKey(PKCS12KeyStore.java:410)
	at sun.security.pkcs12.PKCS12KeyStore.engineGetEntry(PKCS12KeyStore.java:1282)
	at java.security.KeyStore.getEntry(KeyStore.java:1521)
	at org.wildfly.security.credential.store.impl.KeyStoreCredentialStore.retrieve(KeyStoreCredentialStore.java:399)
	... 37 more
Caused by: java.security.NoSuchAlgorithmException: 1.2.840.113549.1.7.1 SecretKeyFactory not available
	at javax.crypto.SecretKeyFactory.<init>(SecretKeyFactory.java:122)
	at javax.crypto.SecretKeyFactory.getInstance(SecretKeyFactory.java:160)
	at sun.security.pkcs12.PKCS12KeyStore.engineGetKey(PKCS12KeyStore.java:387)
	... 40 more

[olukas]

Failures in KeyStoreCredentialStoreTest should not be related to this fix.

[hkalina]

Agree with this changes, but maybe would be better to merge specialchars.properties with clear-special.properties, as they test the same thing.

[olukas]

@honza889 +1 for merge properties files and also testPlainFileSpecialChars() with testSpecialChar_*(). However I suggest one @Test for every user/password with special char (when something goes wrong then you see every failing special char, not only the first one).

[hkalina]

@olukas +1 feel free to do so

[hkalina]

(suggested test refactoring can wait, accepting as is)