[ELY-923] Caching realm - added caching credentials and attributes #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlloyd
reviewed
Feb 16, 2017
|
|
||
| AuthorizationIdentity authorizationIdentity = null; | ||
| Attributes attributes = null; | ||
| Map<Class, Credential> credentialsByType = new HashMap<>(); |
There was a problem hiding this comment.
Could you use an IdentityCredentials instance here?
|
@dmlloyd Updated to use IdentityCredentials instead. Is it ok now? |
dmlloyd
approved these changes
Feb 27, 2017
darranl
approved these changes
Feb 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching identity attributes and credentials (acquiring, evidence verification kept without cache).
https://issues.jboss.org/browse/ELY-923 (reported as ldap related issue)
https://issues.jboss.org/browse/ELY-915 (the same issue for filesystem realm)
(no subsystem part)