Don't use absolute URI for the login page forward call #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darranl
requested changes
Feb 28, 2017
| sb.append(requestURI.getHost()); | ||
| sb.append(':').append(requestURI.getPort()); | ||
| sb.append(loginPage); | ||
| sendPage(sb.toString(), request, response); |
There was a problem hiding this comment.
I see why you have needed to remove this as we need to cope with both a forward and direct resource access within sendPage but at the very end of sendPage we fall through so sendRedirect I think we need it to be back to a URI at that point.
stuartwdouglas
force-pushed
the
form-auth-issue
branch
from
ad8716d
to
a70c41a
Compare
darranl
approved these changes
Feb 28, 2017
fjuma
approved these changes
Feb 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.