[ELY-989] Added AuthenticationContextTest #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaarok
approved these changes
Mar 6, 2017
|
@dmlloyd what do you think about merging this one? I think you have changes coming in this area so adding additional tests may impact that. |
|
I think it's okay to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.jboss.org/browse/ELY-989
Tests
replaceRuleConfiguration()andreplaceRuleSsl()are ignored due to https://issues.jboss.org/browse/ELY-988Tests
addRuleCtxConfigurationAtTheStart(),addRuleCtxConfigurationInTheMiddle(),addRuleCtxSslAtTheStart(),addRuleCtxSslInTheMiddle()are currently ignored and not implemented due to https://issues.jboss.org/browse/ELY-987 - I want to avoid creating tests which actually consider a wrong behavior as correct. I will implement these tests later, when ELY-987 will be resolved.Method
assertExpectedRuleNodealso includes commented assert for Rules - due to issue https://issues.jboss.org/browse/ELY-986 - it should be uncommented when ELY-986 will be fixed.