[ELY-1009] Default settings of SSL session caching for Elytron *-ssl-context are not safe #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darranl
requested changes
Mar 22, 2017
| @@ -315,8 +313,8 @@ public SSLContextBuilder setWrap(final boolean wrap) { | |||
| final SSLContext sslContext = sslContextFactory.create(); | |||
| SSLSessionContext sessionContext = clientMode ? sslContext.getClientSessionContext() : sslContext.getServerSessionContext(); | |||
| if (sessionContext != null) { | |||
| sessionContext.setSessionCacheSize(sessionCacheSize); | |||
| sessionContext.setSessionTimeout(sessionTimeout); | |||
| if (sessionCacheSize > 0) sessionContext.setSessionCacheSize(sessionCacheSize); | |||
There was a problem hiding this comment.
I think this needs to be >= 0 and ensure the default if never set is -1
Although we don't want the default to be '0' it is still a valid value that could be set.
*-ssl-context are not safe
|
Submitted the requested changes. |
darranl
approved these changes
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wildfly-elytron: https://issues.jboss.org/browse/ELY-1009
JBEAP: https://issues.jboss.org/browse/JBEAP-9481