Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELY-1060] [JBEAP-8793] Coverity static analysis, dereference after null check, KeyStoreCredentialStore (Elytron) #751

Merged
merged 1 commit into from Apr 6, 2017
Merged

[ELY-1060] [JBEAP-8793] Coverity static analysis, dereference after null check, KeyStoreCredentialStore (Elytron) #751

merged 1 commit into from Apr 6, 2017

Conversation

ivassile
Copy link
Contributor

@ivassile ivassile commented Apr 4, 2017

@darranl darranl added the +1 DAL label Apr 5, 2017
darranl
darranl approved these changes Apr 5, 2017
View reviewed changes
Copy link
Contributor

@darranl darranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a major issue but I think in general the commit messages should just reference the community issue - the PR description can then contain the link to the JBEAP issue if it is driven by one of those.

@ivassile
Copy link
Contributor Author

ivassile commented Apr 5, 2017

@darranl Thank you for the clarification. I started recently adding the JBEAP issue in the commit message, but will stop doing that.

@pskopek pskopek added the +1 PS label Apr 6, 2017
@pskopek pskopek merged commit 9bd20ae into wildfly-security:master Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darranl darranl darranl approved these changes

@pskopek pskopek pskopek approved these changes

Assignees
No one assigned
Labels
+1 DAL +1 PS
Projects
None yet
Milestone
No milestone
3 participants
@ivassile @darranl @pskopek