[Ely 584] used methods, AuthenticationConfiguration.EMPTY is flaged as deprecated #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
We require that all contributions be made under the terms of the MIT License, http://www.opensource.org/licenses/mit-license.php. Do you agree to the these terms? |
|
Would you be able to update either your profile or reply here with your name, so we know who this is coming from? We need this for our records :) |
|
This is OK to test. |
|
I agree.
(Sure, I'm gonna go fill out the profile right now :) )
…On Thursday, May 18, 2017, Kabir Khan ***@***.***> wrote:
Would you be able to update either your profile or reply here with your
name, so we know who this is coming from? We need this for our records :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#819 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZPTl-Vb1y2v4y8O6dEtLG1rHwvkgHfBks5r7BOpgaJpZM4Nd3gG>
.
|
|
Works now. |
|
This is OK to test |
|
Changes requested by @darranl : as a later API change there is a big risk that it could affect WildFly Core and WildFly and any clients we don't know about that may have used the field. It would be safer to leave the field public but flag it as deprecated. |
9788072178346
force-pushed
the
ELY-584
branch
2 times, most recently
from
95c8ecf
to
2de0a77
Compare
thaarok
approved these changes
May 22, 2017
9788072178346
changed the title
|
this is ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added method empty() for AuthenticationConfiguration to make things consistent.