[ELY-125] Add a DER encoder and decoder #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @author <a href="mailto:fjuma@redhat.com">Farah Juma</a> | ||
| */ | ||
| public class PosByteArrayInputStream extends ByteArrayInputStream { |
There was a problem hiding this comment.
You could use ByteIterator instead (see #81) once that's all merged and sorted out. Then you can also get rid of all the IOException which might make things simpler.
There was a problem hiding this comment.
That's a good point, I'll do that.
|
This looks good but it needs rebasing now that #81 has been merged |
|
Rebased and updated DERDecoder so that it uses ByteIterator instead of ByteArrayInputStream. |
| public class DERDecoder implements ASN1Decoder { | ||
|
|
||
| private ByteIterator bi; | ||
| private LinkedList<DecoderState> states = new LinkedList<DecoderState>(); |
There was a problem hiding this comment.
This could probably be an ArrayDeque instead, which also implements the stack contract but is much more memory performant.
|
Looks great other than (very) minor notes. |
|
Reviewed, looks good. |
|
Updated to use an ArrayDeque for the states in DEREncoder and DERDecoder. |
dmlloyd
added a commit
that referenced
this pull request
Dec 8, 2014
[ELY-125] Add a DER encoder and decoder
darranl
pushed a commit
to darranl-archive/2020-wildfly-elytron
that referenced
this pull request
Jan 7, 2019
Masked Password related changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ELY-125