[ELY-1150] - Revisit branches in handleOne method in ServerAuthenticationContext.createCallbackHandler() #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darranl
reviewed
Jun 7, 2017
dmlloyd
requested changes
Jun 7, 2017
| @@ -1031,6 +1034,7 @@ private void handleOne(final Callback[] callbacks, final int idx) throws IOExcep | |||
| log.tracef("Handling CachedIdentityAuthorizeCallback: principal = %s authorizedIdentity = %s", principal, authorizedIdentity); | |||
There was a problem hiding this comment.
Three lines before this one is a return statement. Should it instead be a handleOne()/continue? And there's another as well.
There was a problem hiding this comment.
Sorry,it is wrong. It should go in the finally block where AI is set.
There was a problem hiding this comment.
@dmlloyd I've removed the try/finally block and return statements. In case an exception is thrown we should not call handleOne.
|
@darranl I can't remember any reason for not calling |
pedroigor
force-pushed
the
ELY-1150
branch
2 times, most recently
from
94d6cad
to
d0ca39f
Compare
…tionContext.createCallbackHandler()
dmlloyd
approved these changes
Jun 7, 2017
darranl
approved these changes
Jun 8, 2017
darranl
approved these changes
Jun 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.