Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELY-1352] Allow all principals to be matched by SimplePermissionMapper #973

Merged
merged 1 commit into from Sep 5, 2017
Merged

[ELY-1352] Allow all principals to be matched by SimplePermissionMapper #973

merged 1 commit into from Sep 5, 2017

Conversation

dmlloyd
Copy link
Contributor

@dmlloyd dmlloyd commented Aug 31, 2017

No description provided.

@dmlloyd dmlloyd requested a review from darranl August 31, 2017 17:56
@dmlloyd dmlloyd added the hold label Aug 31, 2017
@dmlloyd dmlloyd force-pushed the ely-1352 branch 2 times, most recently from fb4c934 to 41f9ad4 Compare August 31, 2017 19:38
@hkalina hkalina added the 1.1.x label Sep 4, 2017
@darranl
Copy link
Contributor

darranl commented Sep 4, 2017

@dmlloyd has this pulled in some other commits not related to the permission mapper?

@darranl
Copy link
Contributor

darranl commented Sep 4, 2017

But the changes in relation to matching all principals look good, most importantly they don't change the API in a negative way.

@dmlloyd
Copy link
Contributor Author

dmlloyd commented Sep 4, 2017

Yep I'll fix it tomorrow.

@dmlloyd dmlloyd removed the hold label Sep 5, 2017
@darranl darranl added the +1 DAL label Sep 5, 2017
@hkalina hkalina added the +1 HK label Sep 5, 2017
@fjuma fjuma added the +1 FJ label Sep 5, 2017
@darranl darranl merged commit 81196db into wildfly-security:1.1.x Sep 5, 2017
@dmlloyd dmlloyd deleted the ely-1352 branch September 5, 2017 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darranl darranl darranl approved these changes

@fjuma fjuma fjuma approved these changes

@hkalina hkalina hkalina approved these changes

Assignees
No one assigned
Labels
1.1.x Critical +1 DAL +1 FJ +1 HK
Projects
None yet
Milestone
No milestone
4 participants
@dmlloyd @darranl @fjuma @hkalina