Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFSSL-79] Create a CONTRIBUTING.md file for new contributors #109

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

Ashpan
Copy link
Contributor

@Ashpan Ashpan commented Oct 6, 2021

CONTRIBUTING.md Outdated
Now you have the repository on your computer!

## Issues
The Wildfly OpenSSL project uses JIRA to manage issues. All issues can be found [here](https://issues.redhat.com/projects/WFSSL/issues).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we have the WFSSL project on JIRA, but I noticed there's a lot of issues for this on Github Issues too. Do we still use Github Issues?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project used to use GitHub Issues but we switched to WFSSL recently.

CONTRIBUTING.md Outdated
@@ -0,0 +1,97 @@
Contributing to Wildfly OpenSSL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Wildfly/WildFly here and below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

CONTRIBUTING.md Outdated
```bash
mvn clean install -Dtest=TestClassName
```
For more information, including details on how Wildfly OpenSSL is integrated in Wildfly Elytron, WildFly Core and WildFly, check out our [developer guide](https://wildfly-security.github.io/wildfly-elytron/getting-started-for-developers/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"how Wildfly OpenSSL is integrated in Wildfly Elytron, WildFly Core and WildFly"

->

"how WildFly OpenSSL is integrated in WildFly Core and WildFly"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@fjuma
Copy link
Contributor

fjuma commented Oct 6, 2021

@Skyllarr Please review and merge when you get a chance. Thanks!

@Skyllarr
Copy link
Contributor

Skyllarr commented Oct 6, 2021

@Skyllarr Please review and merge when you get a chance. Thanks!

@fjuma Approved. However I do not have write access to this repostitory so I cannot merge myself.

@fjuma fjuma merged commit 3d88c5f into wildfly-security:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants