This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
SWARM-856: main() clear up in examples repo #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- There are many usages of main() in our examples that don't require a main() as they can be configured through project-stages.yml. Modifications ------------- Removed all Shrinkwrap specific examples that can be achieved with a `war` project type and project-stages.yml. Modified remaining main() examples to use project-stages.yml instead. Result ------ No impact to product, simplified examples
bobmcwhirter
approved these changes
Dec 7, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are many usages of main() in our examples that don't require a main() as they can be configured through project-stages.yml.
Modifications
Removed all Shrinkwrap specific examples that can be achieved with a
warproject type and project-stages.yml.Modified remaining main() examples to use project-stages.yml instead.
Result
No impact to product, simplified examples