Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

SWARM-940: NoClassDefFoundError for ServiceClient #281

Merged
merged 1 commit into from
Jan 3, 2017
Merged

SWARM-940: NoClassDefFoundError for ServiceClient #281

merged 1 commit into from
Jan 3, 2017

Conversation

kenfinnigan
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you created a JIRA and used it in the commit message?
  • Have you checked to ensure there aren't other open Pull Requests for the same issue?
  • Have you built the project locally prior to submission with mvn clean install?

Motivation

ServiceClient on the constructed interface was failing to be class loaded within the deployment.

Modifications

Modified cdi-jaxrsapi to have the API classes, ServiceClient and @service, outside in a separate API jar which the fraction then has as a dependency and defines a module.xml for.

This brings it into line with how the Netflix libraries are brought in.

Result

Fixed CNFE for ServiceClient

Motivation
----------
ServiceClient on the constructed interface was failing to be class loaded within the deployment.

Modifications
-------------
Modified cdi-jaxrsapi to have the API classes, ServiceClient and @service, outside in a separate API jar which the fraction then has as a dependency and defines a module.xml for.

This brings it into line with how the Netflix libraries are brought in.

Result
------
Fixed CNFE for ServiceClient
Copy link
Contributor

@bobmcwhirter bobmcwhirter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marked as breaking_change in JIRA due to package change.

@bobmcwhirter bobmcwhirter merged commit ff91f9b into thorntail:master Jan 3, 2017
@kenfinnigan kenfinnigan deleted the SWARM-940 branch January 3, 2017 19:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants