This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
SWARM-1944: MP FT - support @Asynchronous @Retry. #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- There is a bug in MP FT implementation. Modifications ------------- Fixed the relevant parts of the code. Result ------ @Retry with @asynchronous (and with fallback) works if an exception is thrown from within a business method.
heiko-braun
approved these changes
Apr 10, 2018
|
LGTM post merge :-) |
|
Though I guess we could have moved the retry logic into |
|
Hm, for sync we create a separate command for each invocation/retry which is imho more correct. For async we only have one command and invoke/retry within its |
|
Got it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a bug in MP FT implementation.
Modifications
Fixed the relevant parts of the code.
Result
@Retry with @asynchronous (and with fallback) works if an exception is
thrown from within a business method.