[EJBCLIENT-236] Add in more trace logging for tracking invocations #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlloyd
requested changes
Jul 13, 2017
| @@ -340,6 +348,7 @@ Discovery getDiscovery() { | |||
| final Map.Entry<URI, String> entry = nodes.entrySet().iterator().next(); | |||
| location = entry.getKey(); | |||
| nodeName = entry.getValue(); | |||
| Logs.INVOCATION.tracef("Performed first-match discovery(target affinity = %s, destination = %s)", new NodeAffinity(nodeName), location); | |||
There was a problem hiding this comment.
This should just log the node name so that we don't pay the construction cost when trace is disabled.
| @@ -352,6 +361,7 @@ Discovery getDiscovery() { | |||
| if (location == null) { | |||
| throw Logs.INVOCATION.selectorReturnedUnknownNode(selector, nodeName); | |||
| } | |||
| Logs.INVOCATION.tracef("Performed first-match discovery, nodes > 1, deployment selector used(target affinity = %s, destination = %s)", new NodeAffinity(nodeName), location); | |||
| @@ -363,6 +373,7 @@ Discovery getDiscovery() { | |||
| if (nodeName == null) { | |||
| throw Logs.INVOCATION.selectorReturnedUnknownNode(selector, location.toString()); | |||
| } | |||
| Logs.INVOCATION.tracef("Performed first-match discovery, nodes > 1, URI selector used(target affinity = %s, destination = %s)", new NodeAffinity(nodeName), location); | |||
| @@ -422,6 +440,9 @@ Discovery getDiscovery() { | |||
| } | |||
| } | |||
| } | |||
| Logs.INVOCATION.tracef("Performing cluster discovery (connected nodes = %s, available nodes = %s)", | |||
| connectedNodes == null ? "null" : connectedNodes, availableNodes == null ? "null" : availableNodes); | |||
There was a problem hiding this comment.
You don't need these conditionals; null values are rendered as "null".
| for (EJBClientConnection connection : configuredConnections) { | ||
| if (! connection.isForDiscovery()) { | ||
| continue; | ||
| } | ||
| Logs.INVOCATION.tracef("EJB discovery provider: attempting to connect to connection %s", connection.getDestination()); |
There was a problem hiding this comment.
This could be extracted to a local variable.
rachmatowicz
force-pushed
the
moreTraceLogging
branch
from
43ebc72
to
fb33f1a
Compare
dmlloyd
approved these changes
Jul 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in more trace logging to the key interceptor and discovery provider used by the client when making invocations.
See: https://issues.jboss.org/browse/EJBCLIENT-236