Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EJBCLIENT-380] Additional logging for mismatched protocol/port confi… #466

Merged
merged 1 commit into from Jul 23, 2020

Conversation

spyrkob
Copy link
Contributor

@spyrkob spyrkob commented Jul 23, 2020

…guration

Issue: https://issues.redhat.com/browse/EJBCLIENT-380

Note this PR depends on XNIO change: xnio/xnio#231 and will fail to build without the upgrade.

@spyrkob
Copy link
Contributor Author

spyrkob commented Jul 23, 2020

@tadamski could you review when you have a moment please?

@tadamski tadamski merged commit 64226f2 into wildfly:master Jul 23, 2020
@tadamski
Copy link
Contributor

@spyrkob merged, thanks
could you please create another one for 4.0 branch?

@spyrkob
Copy link
Contributor Author

spyrkob commented Jul 23, 2020

@tadamski, I created #467 for 4.0 port.
Just to double check - this PR will not compile without the XNIO changes - should this be merged in before XNIO PR?

@tadamski
Copy link
Contributor

@spyrkob yeah, this was my mistake - I will ask Flavia if she could do a XNIO release and will do upgrade on top of that merge; OTOH I will merge 4.0 only after xnio upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants