EJBCLIENT-398 Implement additional timeout also for cluster discovery #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chengfang FIY This is follow up PR to #473, could you review it? |
|
Added a hold label as we're evaluate various approaches, based on discussion in https://issues.redhat.com/browse/EJBCLIENT-356 (EJB client API blocks invocation until all configured connections are established/discovered). |
src/main/java/org/jboss/ejb/client/DiscoveryEJBClientInterceptor.java
Outdated
Show resolved
Hide resolved
TomasHofman
force-pushed
the
EJBCLIENT-398-4.0
branch
from
6e15f1b
to
837ad29
Compare
|
@TomasHofman could you rebase? There was another PR [EJBCLIENT-400] Put all system properties into one location #501 , which changed the same classes. |
(cherry picked from commit 777bfc3)
TomasHofman
force-pushed
the
EJBCLIENT-398-4.0
branch
from
837ad29
to
d1fc012
Compare
|
@chengfang rebased, thanks for notice. |
chengfang
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/JBEAP-20666
Upstream Issue: https://issues.redhat.com/browse/EJBCLIENT-398
Upstream PR: #498
The "discovery.additional-timeout" was implemented previously in
DiscoveryEJBClientInterceptor#doAnyDiscovery(). This PR implements the same functionality for cluster discovery.