[master] [EJBCLIENT-406] Adjust capturing of AuthenticationContext after interceptors. #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darranl
force-pushed
the
EJBCLIENT-406/master
branch
from
83e8f90
to
b2c57e8
Compare
…ntly used for session creation.
…tionContext as common to both implementations.
… discovery. We don't have a mechanism to pass it over the discovery APIs so instead ensure it is associated with the thread to be recaptured.
…xt after the application interceptors. Ensure the captured AuthenticationContext is preferred over the originally captured context.
darranl
force-pushed
the
EJBCLIENT-406/master
branch
from
b2c57e8
to
771357f
Compare
chengfang
approved these changes
May 27, 2021
tadamski
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AuthenticationContext APIs within Elytron are build around being able to wrap an invocation so the context can be set and cleared automatically around the invocation.
Client side interceptors should be an ideal place for this kind of wrapping but working with this there were some differences in behaviour regarding how the context was captured and used, this PR contains a sequence of changes to clean up this behaviour and make it consistent.
https://issues.redhat.com/browse/EJBCLIENT-406