Allowing JavaEE <-> JakartaEE interoperability scenarios #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ropalka
changed the title
tadamski
approved these changes
Jun 23, 2022
chengfang
reviewed
Jun 27, 2022
javax/src/main/java/org/jboss/ejb/protocol/remote/EJBClientChannel.java
Outdated
Show resolved
Hide resolved
javax/src/main/java/org/jboss/ejb/protocol/remote/EJBServerChannel.java
Outdated
Show resolved
Hide resolved
…ios. This introduces new EJB protocol version number 4. Protocol versions 1 2 and 3 mean JBoss EJB Client runs in JavaEE environment. Protocol versions 4 and above mean JBoss EJB Client runs in JakartaEE environment.
chengfang
reviewed
Jun 28, 2022
chengfang
reviewed
Jun 28, 2022
chengfang
approved these changes
Jun 29, 2022
fl4via
reviewed
Jul 5, 2022
| @@ -23,7 +23,11 @@ | |||
| */ | |||
| final class Protocol { | |||
|
|
|||
| public static final int LATEST_VERSION = 3; | |||
| static final int JAVAEE_PROTOCOL_VERSION = 3; | |||
| static final int JAKARTAEE_PROTOCOL_VERSION = 4; | |||
There was a problem hiding this comment.
I really would like to validate if this is necessary or if a simple attribute in the remote outbound connection could be used to indicate the need for transformation without an upgrade in the protocol version
There was a problem hiding this comment.
Yes, this is really necessary. Otherwise Jakarta EE side wouldn't know if communicating oposite side runs in Java EE or in Jakarta EE environment @fl4via .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/EJBCLIENT-419