[EJBCLIENT-419] Implement EE interoperability (disabled by default, enabled via org.wildfly.ee.interoperable sys prop) #557
Conversation
…ios. This introduces new EJB protocol version number 4. Protocol versions 1 2 and 3 mean JBoss EJB Client runs in JavaEE environment. Protocol versions 4 and above mean JBoss EJB Client runs in JakartaEE environment.
|
@ropalka please review as well |
| * Indicates if EE interoperable mode is enabled. | ||
| */ | ||
| public static final boolean EE_INTEROPERABLE_MODE = Boolean.parseBoolean( | ||
| org.wildfly.security.manager.WildFlySecurityManager.getPropertyPrivileged("org.wildfly.ee.interoperable", "false")) |
There was a problem hiding this comment.
for now I'm keeping this property duplicated across the affected projects (but as Richard pointed, maybe we should move this to marshalling?
There was a problem hiding this comment.
I'm fine with splitting it into multiple components - this is something we can fix later if needed.
fl4via
force-pushed
the
EJBCLIENT-419_Final
branch
from
6d173c8
to
99d2454
Compare
|
@tadamski should we enable testing with the system property enabled? Notice that the test will still ignore the ee interoperability because both ends will be Jakarta. On the other hand, at least this small bit will be test. Just let me know what you prefer. |
| * @author Flavia Rainone | ||
| * @author Richard Opalka | ||
| */ | ||
| class EEInteroperability { |
| class EEInteroperability { | ||
| // Batavia transformer sensible constant - it can start with either "javax." or "jakarta." if transformation was performed | ||
| private static final String VARIABLE_CONSTANT = "javax.ejb.FAKE_STRING"; | ||
| public static final boolean JAKARTAEE_ENVIRONMENT = VARIABLE_CONSTANT.startsWith("jakarta"); |
There was a problem hiding this comment.
No need for public classifier for package private class
| /** | ||
| * Indicates if EE interoperable mode is enabled. | ||
| */ | ||
| public static final boolean EE_INTEROPERABLE_MODE = Boolean.parseBoolean( |
There was a problem hiding this comment.
No need for public classifier for package private class
There was a problem hiding this comment.
If we would reorder JAKARTAEE_ENVIRONMENT and Boolean.parseBoolean() in the condition then we wouldn't need to read the system property (access the file system) when JavaEE environment is detected.
| * Indicates if EE interoperable mode is enabled. | ||
| */ | ||
| public static final boolean EE_INTEROPERABLE_MODE = Boolean.parseBoolean( | ||
| org.wildfly.security.manager.WildFlySecurityManager.getPropertyPrivileged("org.wildfly.ee.interoperable", "false")) |
There was a problem hiding this comment.
I'm fine with splitting it into multiple components - this is something we can fix later if needed.
| * @param marshallingConfiguration the marshalling configuration that will be used by the endpoint | ||
| * @param channelProtocolVersion the channel protocol version used by the endpoint | ||
| */ | ||
| public static void handleInteroperability(MarshallingConfiguration marshallingConfiguration, int channelProtocolVersion) { |
There was a problem hiding this comment.
No need for public classifier for package private class
| } | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
Please add private constructor to forbid instantiating this utility class.
… enable it only when org.wildfly.ee.namespace.interop system property is true Signed-off-by: Flavia Rainone <frainone@redhat.com>
fl4via
force-pushed
the
EJBCLIENT-419_Final
branch
from
99d2454
to
09b93fe
Compare
|
@fl4via I think it will be good to enable this EE Interop for testing in this project, say, in surefire config. |
javax/src/main/java/org/jboss/ejb/protocol/remote/EENamespaceInteroperability.java
Show resolved
Hide resolved
Jira: https://issues.redhat.com/browse/EJBCLIENT-419