[EJBCLIENT-505] CI Add integration testing to CI script #639
Conversation
.github/workflows/integration.sh
Outdated
| @@ -0,0 +1,7 @@ | |||
| echo "INTEGRATION TESTS" | |||
|
|
|||
| git clone https://github.com/wildfly/ejb-client-testsuite | |||
There was a problem hiding this comment.
we can clone a shallow copy of the repo, to speed it up a bit:
git clone --depth=1 https://github.com/wildfly/ejb-client-testsuite
.github/workflows/integration.sh
Outdated
|
|
||
| cd ejb-client-testsuite | ||
|
|
||
| mvn clean test |
There was a problem hiding this comment.
we can use the options below to filter out a lot of useless output:
mvn -B -ntp
.github/workflows/integration.yml
Outdated
| - name: Configure runner - Linux | ||
| if: contains(matrix.os, 'ubuntu') | ||
| run: | | ||
| sudo bash -c "echo '127.0.0.1 localhost localhost.localdomain localhost4 localhost4.localdomain4' > /etc/hosts" | ||
| sudo bash -c "echo '::1 localhost localhost.localdomain localhost6 localhost6.localdomain6' >> /etc/hosts" |
There was a problem hiding this comment.
I believe these lines are no longer needed. They were already deleted from other workflow/*.yml files.
|
In the integration test log, there is one line indicating that the integration testsuite is cloning jboss-ejb-client: Executing command git clone -b main --single-branch https://github.com/wildfly/jboss-ejb-client in directory /home/runner/work/jboss-ejb-client/jboss-ejb-client/ejb-client-testsuite/snapshots/target So the main branch is cloned, which does not contain the changes in the PR that was triggering this test run yet. So looks like the integration testsuite run will always be a step behind. |
|
@chengfang thanks for the review - I have fixed all the mentioned issues; I have also update the build script so that the testsuite is build in two steps; this is required after merging Marek's bom PR |
|
|
||
| cd ejb-client-testsuite | ||
|
|
||
| mvn -B -ntp package -DspecificModule=prepare --batch-mode -Dejb.client.repository=https://github.com/${EJB_CLIENT_REPOSITORY} -Dejb.client.branch=${EJB_CLIENT_BRANCH} |
There was a problem hiding this comment.
--batch-mode is the same as -B, which is already in this command.
| cd ejb-client-testsuite | ||
|
|
||
| mvn -B -ntp package -DspecificModule=prepare --batch-mode -Dejb.client.repository=https://github.com/${EJB_CLIENT_REPOSITORY} -Dejb.client.branch=${EJB_CLIENT_BRANCH} | ||
| mvn -B -ntp dependency:tree clean verify --fail-at-end --batch-mode |
There was a problem hiding this comment.
we should be able to remove --batch-mode
|
the integration test job failed, with errors like the below (there may be other errors): Executing command git clone -b EJBCLIENT-505 --depth=1 --single-branch https://github.com/wildfly/jboss-ejb-client jboss-ejb-client in directory /home/runner/work/jboss-ejb-client/jboss-ejb-client/ejb-client-testsuite/snapshots/target So the branch the test is trying to clone is only available in the PR sender's fork, not in the upstream repo yet. |
tadamski
force-pushed
the
EJBCLIENT-505
branch
2 times, most recently
from
6b7af67
to
6d96a68
Compare
https://issues.redhat.com/browse/EJBCLIENT-505