Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-14822] Additional PostBuild tests for the archetypes #16

Merged
merged 1 commit into from Jun 16, 2021

Conversation

WolfgangHG
Copy link
Contributor

@WolfgangHG WolfgangHG commented Mar 26, 2021

@boris-unckel
Copy link
Contributor

@WolfgangHG I have created a Jira issue for your work. You have to change the commit message to
[WFLY-14821] Additional PostBuild tests for the archetypes <--- title of the commit
Fixes https://issues.redhat.com/browse/WFLY-14821 <-- body message of the commit

@WolfgangHG WolfgangHG changed the title Additional PostBuild tests for the archetypes [WFLY-14821] Additional PostBuild tests for the archetypes May 26, 2021
@WolfgangHG
Copy link
Contributor Author

I made some changes and hopefully did the correct thing ;-). Sorry, I am a newbie to Git.

@boris-unckel
Copy link
Contributor

Try locally with 'git commit --amend' and then 'git push --force origin master'
You didn't setup a branch but commited directly to master - try to avoid that in the future. (git checkout -b myNewBranch)

@emmartins
Copy link
Collaborator

@WolfgangHG @boris-unckel hi, WFLY-14821 seems unrelated to this change, is that the correct JIRA?

@boris-unckel
Copy link
Contributor

@WolfgangHG Hello Wolfgang, @emmartins is right. My apologies posting the wrong link. The correct one is https://issues.redhat.com/browse/WFLY-14822 "WildFly Maven archetypes: Additional PostBuild tests". Wolfgang could you please change this in the commit message (git command see above) and in the pull request?

@WolfgangHG WolfgangHG changed the title [WFLY-14821] Additional PostBuild tests for the archetypes [WFLY-14822] Additional PostBuild tests for the archetypes May 27, 2021
@WolfgangHG
Copy link
Contributor Author

@boris-unckel done - hope it is OK now ;-)

@emmartins emmartins merged commit 086ee30 into wildfly:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants