Optional connectionTimeout property support added #159
Conversation
mP1
commented
Feb 17, 2020
•
mP1
commented
- Closes https://issues.redhat.com/browse/WFARQ-3?_sscc=t
There was a problem hiding this comment.
If you don't have time to make this change small change I can definitely do that. This also looks like it resolves https://issues.redhat.com/browse/WFARQ-3. If you could add [WFARQ-3] as a prefix to the commit message that would be helpful. Again though I'm happy to do so :)
| @@ -103,6 +103,12 @@ public final void start() throws LifecycleException { | |||
| .setPort(containerConfig.getManagementPort()) | |||
| .setAuthenticationConfigUri(authenticationConfig); | |||
|
|
|||
| // only "copy" the timeout if one was set. | |||
| final int connectionTimeout = containerConfig.getConnectionTimeout(); | |||
| if(0 != connectionTimeout) { | |||
There was a problem hiding this comment.
This should be if (connectionTimeout > 0). The internal code currently does handle this, but we should not rely on that.
There was a problem hiding this comment.
Changed to the gt test.
|
@jamezp Any chance for a new release ? |
|
@mP1 it's going to be at least a couple weeks before I'd be able to cut a release of this. It would be a beta release as well. Will that be an issue? |
|
@jamezp No just wondering, thanks for the reply |
|
@jamezp , is there a chance that this feature could be cherry-picked into and released within the |
|
@QazerLab Since it's more of a feature I'd rather not back port it to 2.x. For 3.0.0 I'd say it's pretty stable now. Any additional changes would be minor bug fixes and changes/fixes for the bootable JAR container. We're likely go final by mid October though. |
|
@jamezp Thanks for clarification! I'll be waiting for 3.0.0 then. |
mP1
deleted the
feature/Optional-connectionTimeout-property-support-added
branch
