Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFARQ-140] Follow up on the application client support. Changed to r… #398

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

jamezp
Copy link
Member

@jamezp jamezp commented Dec 12, 2023

…equire injection via @ArquillianResource annotation and minor clean up.

https://issues.redhat.com/browse/WFARQ-140

…equire injection via @ArquillianResource annotation and minor clean up.

https://issues.redhat.com/browse/WFARQ-140
Signed-off-by: James R. Perkins <jperkins@redhat.com>
@jamezp
Copy link
Member Author

jamezp commented Dec 12, 2023

@starksm64 does this look okay? There are a few configuration name changes and to inject the AppClientWrapper you need to use an @ArquillianResource annotation. That feels more standard IMO.

The property name change is: appClientSh -> appClientCommand

Also in the AppClientWrapper I removed the quit() method in favor of implementing AutoCloseable.

Copy link
Contributor

@starksm64 starksm64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamezp jamezp merged commit 39ef5fb into wildfly:main Dec 12, 2023
5 checks passed
@jamezp jamezp deleted the WFARQ-140 branch December 12, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants