WFLY-3882 ManagementClient Domain Hosts #5
Conversation
…hat are included in the domain
| @@ -229,6 +231,22 @@ public boolean isServerStarted(Server server) { | |||
| return false; | |||
| } | |||
|
|
|||
| public HashSet<String> getDomainHosts() throws Exception{ | |||
There was a problem hiding this comment.
Return a Set<String> instead of HashSet<String>.
…hat are included in the domain
|
Why does this belong in the arquillian container versus in some utility code in a testsuite? All the other public API in this class is used within this project itself to help Arquillian manage a domain. Also, what's the use case for this? The JIRA trail leads back to https://issues.jboss.org/browse/WFLY-1264 but I don't see how this provides any sort of notification capability. |
| readRootNode(); | ||
|
|
||
| if (rootNode.isDefined()) | ||
| if (rootNode.get("host").isDefined()){ |
There was a problem hiding this comment.
Always use this idiom for this kind of thing:
if (rootNode.hasDefined("host"))
Never call ModelNode.get unless you are sure what you are getting exists, or you are willing to create the node. ModelNode provides a fluent API, so one effect of that is get(...) actuall mutates the node you call it on.
…hat are included in the domain
|
I have placed this modification in the ManagementClient because in the description of WFLY-1264, ManagementClient is to be used (Extention of functionality of ManagementClient). I will also add a PR to WFLY-1264 of the test which will display the notifications. |
|
PR for WFLY-1264 sent : wildfly/wildfly#6781 |
|
This isn't a notification mechanism, so it's not clear to me how this meets the WFLY-1264 requirements. This work needs to start with a full analysis in WFLY-1264 of what the requirements are and what the use cases are to support those requirements. I'm going to close this pending that analysis. |
Addition of a function at ManagementClient that returns the hosts that are included in the domain.