WFARQ-12 Allow extending ArquillianConfig service #68
Conversation
arcivanov
force-pushed
the
ARQ-2021
branch
2 times, most recently
from
3384c49
to
89323d4
Compare
|
Fine with me |
arcivanov
changed the title
| @@ -105,6 +105,10 @@ | |||
| try { | |||
| Collection<Archive<?>> auxArchives = testDeployment.getAuxiliaryArchives(); | |||
| JavaArchive archive = generateArquillianServiceArchive(auxArchives); | |||
|
|
|||
| Processor processor = new Processor(testDeployment, protocolProcessors); | |||
| processor.process(archive); | |||
There was a problem hiding this comment.
I'm not sure I understand why this is needed. Couldn't the loop just happen here instead of a new class?
There was a problem hiding this comment.
This is taken directly from Servlet 3.0 protocol. I decided not to breed custom types of solutions. I can obviously implement directly if you'd like.
There was a problem hiding this comment.
Ah okay. I think I'd prefer it here. No need to abstract IMO :)
There was a problem hiding this comment.
I'll be back in around an hour or so. If you don't get a chance to get to it I will merge it and change it, then cut a 1.1 release :).
There was a problem hiding this comment.
I'll do the inline implementation :)
|
@jamezp done |
WFARQ-12 Allow extending ArquillianConfig service
|
Alright 1.1.0.Beta2 has been released. It make take a few hours to hit maven central, but it's in the JBoss Nexus Repository. |
|
Thanks a lot, really appreciate it! |
No description provided.