[CLOUD-3951] Bump maven module version to 3.6 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maven 3.5 got EOL'd. Bump it to v3.6 Signed-off-by: Daniel Kreling <dkreling@redhat.com>
|
That is fine with me, seems that we will have to do this bump in master too. @luck3y wdyt? |
luck3y
reviewed
Mar 30, 2021
| # required to have maven enabled. | ||
| source $JBOSS_CONTAINER_MAVEN_35_MODULE/scl-enable-maven | ||
| source $JBOSS_CONTAINER_MAVEN_36_MODULE/scl-enable-maven |
There was a problem hiding this comment.
For ubi7 SCL will likely still be there, but on 8, I'm not sure if this will be present. So it would be wise to build a test image using 8 / JDK 11 and see if maven is populated correctly in the environment (and on the path etc).
|
@dbkreling Is this going into the next EAP release? |
|
@luck3y That would be good. There were some (8 to be exact) behave tests failing, but they don't seem to be related to the maven upgrade. |
luck3y
approved these changes
Apr 14, 2021
luck3y
added a commit
to luck3y/wildfly-cekit-modules
that referenced
this pull request
Apr 14, 2021
[CLOUD-3951] Bump maven module version to 3.6
jfdenise
pushed a commit
to jfdenise/wildfly-cekit-modules
that referenced
this pull request
Apr 15, 2021
[CLOUD-3951] Bump maven module version to 3.6
luck3y
added a commit
to luck3y/wildfly-cekit-modules
that referenced
this pull request
Apr 15, 2021
[CLOUD-3951] Bump maven module version to 3.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maven 3.5 got EOL'd. Bump it to v3.6
Signed-off-by: Daniel Kreling dkreling@redhat.com